rootmodule: Fix schema/module update detection #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
b-fix-schema-update-detection
branch
from
45ae701
to
567ca38
Compare
radeksimko
changed the title
radeksimko
force-pushed
the
b-fix-schema-update-detection
branch
from
567ca38
to
9525354
Compare
paultyng
approved these changes
Jun 24, 2020
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing a bug where we would detect plugin lock file change as module change and vice versa. Therefore the server would attempt to update plugins when module change and update module cache when plugins change. This could lead to a situation where obtaining schema errors out because the plugin lock file wasn't written to the disk yet (modules are updated first during
init).This was introduced as part of #167 (so far unreleased 😅 )
The watcher logic is entirely untested at this point - something to address.
I'm just not sure what the best testing strategy there is yet. Should we entirely mock out the watcher, or genuinely update real files on the filesystem in TMPDIR? I feel like that question needs to be answered, but I'd like to answer it in a separate PR.